selftests: sync: differentiate between sync unsupported and access errors
authorShuah Khan <shuahkh@osg.samsung.com>
Sat, 22 Jul 2017 02:23:11 +0000 (20:23 -0600)
committerShuah Khan <shuahkh@osg.samsung.com>
Fri, 28 Jul 2017 19:19:55 +0000 (13:19 -0600)
Sync test doesn't differentiate between sync unsupported and test run
by non-root user and treats both as unsupported cases.

Fix it to add handling for these two different scenarios.

Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.com>
tools/testing/selftests/sync/sync_test.c

index 62fa666e501a4548a7a1b0a3e2ea87e35b94eaeb..86ae45ad0347ac193ef2ee70959ee9aedec5f5c8 100644 (file)
@@ -31,6 +31,7 @@
 #include <sys/types.h>
 #include <sys/stat.h>
 #include <sys/wait.h>
+#include <errno.h>
 
 #include "synctest.h"
 
@@ -56,18 +57,32 @@ static int run_test(int (*test)(void), char *name)
 static int sync_api_supported(void)
 {
        struct stat sbuf;
+       int ret;
+
+       ret = stat("/sys/kernel/debug/sync/sw_sync", &sbuf);
+       if (!ret)
+               return 0;
+
+       if (errno == ENOENT) {
+               printf("SKIP: Sync framework not supported by kernel\n");
+               exit(0);
+       }
+       if (errno == EACCES) {
+               printf("SKIP: Run Sync test as root.\n");
+               exit(0);
+       }
+
+       perror("stat");
+       exit(ret);
 
-       return 0 == stat("/sys/kernel/debug/sync/sw_sync", &sbuf);
 }
 
 int main(void)
 {
        int err = 0;
 
-       if (!sync_api_supported()) {
-               printf("SKIP: Sync framework not supported by kernel\n");
+       if (!sync_api_supported())
                return 0;
-       }
 
        printf("[RUN]\tTesting sync framework\n");