wifi: rt2x00: fix CRC_CCITT dependency
authorArnd Bergmann <arnd@arndb.de>
Thu, 31 Jul 2025 07:58:33 +0000 (09:58 +0200)
committerJohannes Berg <johannes.berg@intel.com>
Tue, 26 Aug 2025 11:44:28 +0000 (13:44 +0200)
Compile-testing this driver on Arm platforms shows a link failure
when the CRC functions are not part of the kernel:

x86_64-linux-ld: drivers/net/wireless/ralink/rt2x00/rt2800lib.o: in function `rt2800_check_firmware':
rt2800lib.c:(.text+0x20e5): undefined reference to `crc_ccitt'

Move the select statement to the correct Kconfig symbol to match
the call site.

Fixes: 311b05e235cf ("wifi: rt2x00: add COMPILE_TEST")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Stanislaw Gruszka <stf_xl@wp.pl>
Reviewed-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Link: https://patch.msgid.link/20250731075837.1969136-1-arnd@kernel.org
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
drivers/net/wireless/ralink/rt2x00/Kconfig

index d66fc839c3ce317d4d23e08fe926d2e6d2b5b834..17f063fc0b576bec6bd8350dff68939e67ed6b28 100644 (file)
@@ -66,7 +66,6 @@ config RT2800PCI
        select RT2X00_LIB_PCI
        select RT2X00_LIB_FIRMWARE
        select RT2X00_LIB_CRYPTO
-       select CRC_CCITT
        select EEPROM_93CX6
        help
          This adds support for rt27xx/rt28xx/rt30xx wireless chipset family.
@@ -142,7 +141,6 @@ config RT2800USB
        select RT2X00_LIB_USB
        select RT2X00_LIB_FIRMWARE
        select RT2X00_LIB_CRYPTO
-       select CRC_CCITT
        help
          This adds support for rt27xx/rt28xx/rt30xx wireless chipset family.
          Supported chips: RT2770, RT2870 & RT3070, RT3071 & RT3072
@@ -217,6 +215,7 @@ config RT2800SOC
 
 config RT2800_LIB
        tristate
+       select CRC_CCITT
 
 config RT2800_LIB_MMIO
        tristate