ALSA: hda/tas2781: Fix EFI name for calibration beginning with 1 instead of 0
authorShenghao Ding <shenghao-ding@ti.com>
Wed, 27 Aug 2025 04:34:03 +0000 (12:34 +0800)
committerTakashi Iwai <tiwai@suse.de>
Wed, 27 Aug 2025 13:06:41 +0000 (15:06 +0200)
A bug reported by one of my customers that EFI name beginning with 0
instead of 1.

Fixes: 4fe238513407 ("ALSA: hda/tas2781: Move and unified the calibrated-data getting function for SPI and I2C into the tas2781_hda lib")
Signed-off-by: Shenghao Ding <shenghao-ding@ti.com>
Link: https://patch.msgid.link/20250827043404.644-1-shenghao-ding@ti.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/hda/codecs/side-codecs/tas2781_hda_i2c.c

index e34b17f0c9b9e2eec40be808059dcea94f91d745..7143926c2c30f35c0edc799444e0ab4019b3b608 100644 (file)
@@ -327,8 +327,8 @@ static int tas2563_save_calibration(struct tas2781_hda *h)
                data[offset] = i;
                offset++;
                for (j = 0; j < TASDEV_CALIB_N; ++j) {
-                       ret = snprintf(var8, sizeof(var8), vars[j], i);
-
+                       /* EFI name for calibration started with 1, not 0 */
+                       ret = snprintf(var8, sizeof(var8), vars[j], i + 1);
                        if (ret < 0 || ret >= sizeof(var8) - 1) {
                                dev_err(p->dev, "%s: Read %s failed\n",
                                        __func__, var8);