PCI/DPC: Push dpc->rp_pio_status assignment into dpc_rp_pio_get_info()
authorBjorn Helgaas <bhelgaas@google.com>
Tue, 30 Jan 2018 18:12:43 +0000 (12:12 -0600)
committerBjorn Helgaas <helgaas@kernel.org>
Tue, 30 Jan 2018 21:26:09 +0000 (15:26 -0600)
Move the dpc->rp_pio_status assignment into dpc_rp_pio_get_info() since
that's where we read rp_pio->status anway.  No functional change intended.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Keith Busch <keith.busch@intel.com>
Reviewed-by: Sinan Kaya <okaya@codeaurora.org>
drivers/pci/pcie/pcie-dpc.c

index fb7ddbe968110be5eb483b7a162b49a1c1ce1b20..7b96169a808ca03ee24fe6d192b277e8557fa1cb 100644 (file)
@@ -158,6 +158,8 @@ static void dpc_rp_pio_get_info(struct dpc_dev *dpc,
        dev_err(dev, "rp_pio_status: %#010x, rp_pio_mask: %#010x\n",
                rp_pio->status, rp_pio->mask);
 
+       dpc->rp_pio_status = rp_pio->status;
+
        pci_read_config_dword(pdev, cap + PCI_EXP_DPC_RP_PIO_SEVERITY,
                              &rp_pio->severity);
        pci_read_config_dword(pdev, cap + PCI_EXP_DPC_RP_PIO_SYSERROR,
@@ -213,7 +215,6 @@ static void dpc_process_rp_pio_error(struct dpc_dev *dpc)
 
        dpc_rp_pio_get_info(dpc, &rp_pio_regs);
 
-       dpc->rp_pio_status = rp_pio_regs.status;
 }
 
 static irqreturn_t dpc_irq(int irq, void *context)