leds: gpio: Utilise PTR_ERR_OR_ZERO()

Avoid a boilerplate code by using PTR_ERR_OR_ZERO() in create_gpio_led().

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20231016161005.1471768-2-andriy.shevchenko@linux.intel.com
Signed-off-by: Lee Jones <lee@kernel.org>

diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c
index debadb48ceda37bbb6533be0227411bbd47eba99..4071cb9eefecbc1a2fd16d153ecc7367d229c91b 100644 (file)
--- a/drivers/leds/leds-gpio.c
+++ b/drivers/leds/leds-gpio.c
@@ -125,16 +125,13 @@ static int create_gpio_led(const struct gpio_led *template,
                return ret;
 
        pinctrl = devm_pinctrl_get_select_default(led_dat->cdev.dev);
-       if (IS_ERR(pinctrl)) {
-               ret = PTR_ERR(pinctrl);
-               if (ret != -ENODEV) {
-                       dev_warn(led_dat->cdev.dev,
-                                "Failed to select %pfw pinctrl: %d\n",
-                                fwnode, ret);
-               } else {
-                       /* pinctrl-%d not present, not an error */
-                       ret = 0;
-               }
+       ret = PTR_ERR_OR_ZERO(pinctrl);
+       /* pinctrl-%d not present, not an error */
+       if (ret == -ENODEV)
+               ret = 0;
+       if (ret) {
+               dev_warn(led_dat->cdev.dev, "Failed to select %pfw pinctrl: %d\n",
+                        fwnode, ret);
        }
 
        return ret;