ASoC: qcom: Fix missing of_node_put() in asoc_qcom_lpass_cpu_platform_probe()
authorLiang He <windhl@126.com>
Sat, 2 Jul 2022 02:01:09 +0000 (10:01 +0800)
committerMark Brown <broonie@kernel.org>
Mon, 4 Jul 2022 11:44:13 +0000 (12:44 +0100)
We should call of_node_put() for the reference 'dsp_of_node' returned by
of_parse_phandle() which will increase the refcount.

Fixes: 9bae4880acee ("ASoC: qcom: move ipq806x specific bits out of lpass driver.")
Co-authored-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Liang He <windhl@126.com>
Link: https://lore.kernel.org/r/20220702020109.263980-1-windhl@126.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/qcom/lpass-cpu.c

index 263a066769d47ed80c4aaa7d1b458d1efb097eb1..8a56f38dc7e86849ac5e0a9541636684e0e9554e 100644 (file)
@@ -1091,6 +1091,7 @@ int asoc_qcom_lpass_cpu_platform_probe(struct platform_device *pdev)
        dsp_of_node = of_parse_phandle(pdev->dev.of_node, "qcom,adsp", 0);
        if (dsp_of_node) {
                dev_err(dev, "DSP exists and holds audio resources\n");
+               of_node_put(dsp_of_node);
                return -EBUSY;
        }