wifi: mt76: mt7996: fix NULL pointer dereference in mt7996_mcu_sta_bfer_he
authorMa Ke <make24@iscas.ac.cn>
Tue, 13 Aug 2024 08:12:42 +0000 (16:12 +0800)
committerFelix Fietkau <nbd@nbd.name>
Fri, 6 Sep 2024 09:14:31 +0000 (11:14 +0200)
Fix the NULL pointer dereference in mt7996_mcu_sta_bfer_he
routine adding an sta interface to the mt7996 driver.

Found by code review.

Cc: stable@vger.kernel.org
Fixes: 98686cd21624 ("wifi: mt76: mt7996: add driver for MediaTek Wi-Fi 7 (802.11be) devices")
Signed-off-by: Ma Ke <make24@iscas.ac.cn>
Link: https://patch.msgid.link/20240813081242.3991814-1-make24@iscas.ac.cn
Signed-off-by: Felix Fietkau <nbd@nbd.name>
drivers/net/wireless/mediatek/mt76/mt7996/mcu.c

index e8d34bfbb41ae0a69798b34a5c0adf7ffbcb2603..8855095fef10a0ceb95c62142270683a74fcec5f 100644 (file)
@@ -1544,6 +1544,9 @@ mt7996_mcu_sta_bfer_he(struct ieee80211_sta *sta, struct ieee80211_vif *vif,
        u8 nss_mcs = mt7996_mcu_get_sta_nss(mcs_map);
        u8 snd_dim, sts;
 
+       if (!vc)
+               return;
+
        bf->tx_mode = MT_PHY_TYPE_HE_SU;
 
        mt7996_mcu_sta_sounding_rate(bf);