drm/hibmc: Call drm_irq_uninstall() unconditionally
authorThomas Zimmermann <tzimmermann@suse.de>
Fri, 25 Jun 2021 08:21:57 +0000 (10:21 +0200)
committerThomas Zimmermann <tzimmermann@suse.de>
Tue, 29 Jun 2021 09:03:24 +0000 (11:03 +0200)
Remove the check around drm_irq_uninstall(). The same test is
done by the function internally. The tested state in irq_enabled
is considered obsolete and should not be used by KMS drivers.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Tian Tao <tiantao6@hisilicon.com>
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20210625082222.3845-3-tzimmermann@suse.de
drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c

index f4bc5386574afefe774bce9f8b03965a2bcba0be..f8ef711bbe5dadd837e19099bfc09ed5239c0550 100644 (file)
@@ -253,8 +253,7 @@ static int hibmc_unload(struct drm_device *dev)
 {
        drm_atomic_helper_shutdown(dev);
 
-       if (dev->irq_enabled)
-               drm_irq_uninstall(dev);
+       drm_irq_uninstall(dev);
 
        pci_disable_msi(to_pci_dev(dev->dev));