spi: spi-qpic-snand: use kmalloc() for OOB buffer allocation
authorGabor Juhos <j4g8y7@gmail.com>
Thu, 20 Mar 2025 18:11:59 +0000 (19:11 +0100)
committerMark Brown <broonie@kernel.org>
Sun, 6 Apr 2025 22:26:09 +0000 (23:26 +0100)
The qcom_spi_ecc_init_ctx_pipelined() function allocates zeroed
memory for the OOB buffer, then it fills the buffer with '0xff'
bytes right after the allocation. In this case zeroing the memory
during allocation is superfluous, so use kmalloc() instead of
kzalloc() to avoid that.

Signed-off-by: Gabor Juhos <j4g8y7@gmail.com>
Link: https://patch.msgid.link/20250320-qpic-snand-kmalloc-v1-1-94e267550675@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-qpic-snand.c

index 17eb67e19132612c4c1a84848fa6f7432b1130a8..a2af731049d48ab617df33db4b58228e01678f80 100644 (file)
@@ -261,7 +261,7 @@ static int qcom_spi_ecc_init_ctx_pipelined(struct nand_device *nand)
        ecc_cfg = kzalloc(sizeof(*ecc_cfg), GFP_KERNEL);
        if (!ecc_cfg)
                return -ENOMEM;
-       snandc->qspi->oob_buf = kzalloc(mtd->writesize + mtd->oobsize,
+       snandc->qspi->oob_buf = kmalloc(mtd->writesize + mtd->oobsize,
                                        GFP_KERNEL);
        if (!snandc->qspi->oob_buf) {
                kfree(ecc_cfg);