netfilter: xt_LOG: don't use xchg() for simple assignment
authorJan Beulich <JBeulich@suse.com>
Wed, 7 Mar 2012 23:45:44 +0000 (23:45 +0000)
committerPablo Neira Ayuso <pablo@netfilter.org>
Mon, 26 Mar 2012 12:00:28 +0000 (14:00 +0200)
At least on ia64 the (bogus) use of xchg() here results in the compiler
warning about an unused expression result. As only an assignment is
intended here, convert it to such.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
include/net/netfilter/xt_log.h

index 7e1544e8f70d36599205fd821f1cdc34705d1676..9d9756cca0132bbc603c313b0ecb18670fef3bb0 100644 (file)
@@ -47,7 +47,7 @@ static void sb_close(struct sbuff *m)
        if (likely(m != &emergency))
                kfree(m);
        else {
-               xchg(&emergency_ptr, m);
+               emergency_ptr = m;
                local_bh_enable();
        }
 }