nvme: fix incorrect sizeof

The plid array, head->plids, is meant to store placement IDs, each of
type u16. But its size has been incorrectly calculated, as the size of
the pointer is being used instead of the size of the object it points
to.

Use the sizeof(*head->plids) in kcalloc so that we don't allocate extra.

Fixes: 38e8397dde63 ("nvme: use fdp streams if write stream is provided")
Reported-by: Caleb Sander Mateos <csander@purestorage.com>
Signed-off-by: Kanchan Joshi <joshi.k@samsung.com>
Reviewed-by: Caleb Sander Mateos <csander@purestorage.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index a9fb8cd544200f7732b29cd00f7a9281011e3a49..a8444d1e83982634c52148687d2ba5a6bc2d8c59 100644 (file)
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -2296,7 +2296,7 @@ static int nvme_query_fdp_info(struct nvme_ns *ns, struct nvme_ns_info *info)
        if (!head->nr_plids)
                goto free;
 
-       head->plids = kcalloc(head->nr_plids, sizeof(head->plids),
+       head->plids = kcalloc(head->nr_plids, sizeof(*head->plids),
                              GFP_KERNEL);
        if (!head->plids) {
                dev_warn(ctrl->device,