media: stm32-dcmi: constify vb2_ops structure
authorGustavo A. R. Silva <garsilva@embeddedor.com>
Thu, 6 Jul 2017 20:05:17 +0000 (16:05 -0400)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Wed, 19 Jul 2017 19:02:50 +0000 (15:02 -0400)
Check for vb2_ops structures that are only stored in the ops field of a
vb2_queue structure. That field is declared const, so vb2_ops structures
that have this property can be declared as const also.

This issue was detected using Coccinelle and the following semantic patch:

@r disable optional_qualifier@
identifier i;
position p;
@@
static struct vb2_ops i@p = { ... };

@ok@
identifier r.i;
struct vb2_queue e;
position p;
@@
e.ops = &i@p;

@bad@
position p != {r.p,ok.p};
identifier r.i;
struct vb2_ops e;
@@
e@i@p

@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
struct vb2_ops i = { ... };

Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Acked-by: Hugues Fruchet <hugues.fruchet@st.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/platform/stm32/stm32-dcmi.c

index 83d32a5d0f4081a1f5a671ab0ac5fca97202c7af..24ef88809d7c3d93c28397a3d5d50bfed03dbfa4 100644 (file)
@@ -662,7 +662,7 @@ static void dcmi_stop_streaming(struct vb2_queue *vq)
                dcmi->errors_count, dcmi->buffers_count);
 }
 
-static struct vb2_ops dcmi_video_qops = {
+static const struct vb2_ops dcmi_video_qops = {
        .queue_setup            = dcmi_queue_setup,
        .buf_init               = dcmi_buf_init,
        .buf_prepare            = dcmi_buf_prepare,