net: dsa: sja1105: Add of_node_put() before return
authorWan Jiabing <wanjiabing@vivo.com>
Thu, 21 Oct 2021 09:46:06 +0000 (05:46 -0400)
committerJakub Kicinski <kuba@kernel.org>
Fri, 22 Oct 2021 21:05:55 +0000 (14:05 -0700)
Fix following coccicheck warning:
./drivers/net/dsa/sja1105/sja1105_main.c:1193:1-33: WARNING: Function
for_each_available_child_of_node should have of_node_put() before return.

Early exits from for_each_available_child_of_node should decrement the
node reference counter.

Fixes: 9ca482a246f0 ("net: dsa: sja1105: parse {rx, tx}-internal-delay-ps properties for RGMII delays")
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
Link: https://lore.kernel.org/r/20211021094606.7118-1-wanjiabing@vivo.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/dsa/sja1105/sja1105_main.c

index 1832d4bd3440a6ffcb269b5474c8826b2df58daf..70ece441b3b8d9513126a42dec0b6fbf33934103 100644 (file)
@@ -1233,8 +1233,10 @@ static int sja1105_parse_ports_node(struct sja1105_private *priv,
                priv->phy_mode[index] = phy_mode;
 
                err = sja1105_parse_rgmii_delays(priv, index, child);
-               if (err)
+               if (err) {
+                       of_node_put(child);
                        return err;
+               }
        }
 
        return 0;