staging: vc04_services: fix information leak in create_component()
authorDan Carpenter <dan.carpenter@linaro.org>
Wed, 13 Mar 2024 18:07:43 +0000 (21:07 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 25 Mar 2024 18:10:01 +0000 (19:10 +0100)
The m.u.component_create.pid field is for debugging and in the mainline
kernel it's not used anything.  However, it still needs to be set to
something to prevent disclosing uninitialized stack data.  Set it to
zero.

Fixes: 7b3ad5abf027 ("staging: Import the BCM2835 MMAL-based V4L2 camera driver.")
Cc: stable <stable@kernel.org>
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/2d972847-9ebd-481b-b6f9-af390f5aabd3@moroto.mountain
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c

index 6ca5797aeae5a5287192231b3cc96bac9e964ab2..4c3684dd902ed420f0e54aeba4346c683f3e00ce 100644 (file)
@@ -939,6 +939,7 @@ static int create_component(struct vchiq_mmal_instance *instance,
        m.u.component_create.client_component = component->client_component;
        strscpy_pad(m.u.component_create.name, name,
                    sizeof(m.u.component_create.name));
+       m.u.component_create.pid = 0;
 
        ret = send_synchronous_mmal_msg(instance, &m,
                                        sizeof(m.u.component_create),