bcachefs: Kill btree_iter_pos_changed()
authorKent Overstreet <kent.overstreet@gmail.com>
Tue, 16 Mar 2021 05:52:55 +0000 (01:52 -0400)
committerKent Overstreet <kent.overstreet@linux.dev>
Sun, 22 Oct 2023 21:08:56 +0000 (17:08 -0400)
this is used in only one place now, so just inline it into the caller.

Signed-off-by: Kent Overstreet <kent.overstreet@gmail.com>
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
fs/bcachefs/btree_iter.c

index 70828d8876f9fc17e97c75c061dbb78eaca3bdca..c1081431a84686bbe41418ba24ad85e1713b1dce 100644 (file)
@@ -1445,13 +1445,16 @@ struct btree *bch2_btree_iter_next_node(struct btree_iter *iter)
 
 /* Iterate across keys (in leaf nodes only) */
 
-static void btree_iter_pos_changed(struct btree_iter *iter, int cmp)
+static void btree_iter_set_search_pos(struct btree_iter *iter, struct bpos new_pos)
 {
+       int cmp = bkey_cmp(new_pos, iter->real_pos);
        unsigned l = iter->level;
 
        if (!cmp)
                goto out;
 
+       iter->real_pos = new_pos;
+
        if (unlikely(btree_iter_type(iter) == BTREE_ITER_CACHED)) {
                btree_node_unlock(iter, 0);
                iter->l[0].b = BTREE_ITER_NO_NODE_UP;
@@ -1481,15 +1484,6 @@ out:
                btree_iter_set_dirty(iter, BTREE_ITER_NEED_TRAVERSE);
        else
                btree_iter_set_dirty(iter, BTREE_ITER_NEED_PEEK);
-}
-
-static void btree_iter_set_search_pos(struct btree_iter *iter, struct bpos new_pos)
-{
-       int cmp = bkey_cmp(new_pos, iter->real_pos);
-
-       iter->real_pos = new_pos;
-
-       btree_iter_pos_changed(iter, cmp);
 
        bch2_btree_iter_verify(iter);
 }