ipmi:msghandler: Don't check for shutdown when returning responses

The lower level interface shouldn't attempt to unregister if it has a
callback in the pending queue.

Signed-off-by: Corey Minyard <cminyard@mvista.com>

diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c
index 6c9773b3c857a02003f62364ae4675e5d26882ec..6a680c559ed1b747150d9b78f9fc81ade2fb9f3d 100644 (file)
--- a/drivers/char/ipmi/ipmi_msghandler.c
+++ b/drivers/char/ipmi/ipmi_msghandler.c
@@ -3893,17 +3893,12 @@ static int handle_ipmb_get_msg_cmd(struct ipmi_smi *intf,
                dev_dbg(intf->si_dev, "Invalid command: %*ph\n",
                        msg->data_size, msg->data);
 
-               mutex_lock(&ipmi_interfaces_mutex);
-               if (!intf->in_shutdown) {
-                       smi_send(intf, intf->handlers, msg, 0);
-                       /*
-                        * We used the message, so return the value
-                        * that causes it to not be freed or
-                        * queued.
-                        */
-                       rv = -1;
-               }
-               mutex_unlock(&ipmi_interfaces_mutex);
+               smi_send(intf, intf->handlers, msg, 0);
+               /*
+                * We used the message, so return the value that
+                * causes it to not be freed or queued.
+                */
+               rv = -1;
        } else {
                recv_msg = ipmi_alloc_recv_msg();
                if (!recv_msg) {
@@ -3984,17 +3979,12 @@ static int handle_ipmb_direct_rcv_cmd(struct ipmi_smi *intf,
                msg->data[4] = IPMI_INVALID_CMD_COMPLETION_CODE;
                msg->data_size = 5;
 
-               mutex_lock(&ipmi_interfaces_mutex);
-               if (!intf->in_shutdown) {
-                       smi_send(intf, intf->handlers, msg, 0);
-                       /*
-                        * We used the message, so return the value
-                        * that causes it to not be freed or
-                        * queued.
-                        */
-                       rv = -1;
-               }
-               mutex_unlock(&ipmi_interfaces_mutex);
+               smi_send(intf, intf->handlers, msg, 0);
+               /*
+                * We used the message, so return the value that
+                * causes it to not be freed or queued.
+                */
+               rv = -1;
        } else {
                recv_msg = ipmi_alloc_recv_msg();
                if (!recv_msg) {