usb: cdns3: remove set but not used variable 'priv_dev'
authorYueHaibing <yuehaibing@huawei.com>
Tue, 3 Sep 2019 12:04:45 +0000 (20:04 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 3 Sep 2019 13:46:46 +0000 (15:46 +0200)
Fixes gcc '-Wunused-but-set-variable' warning:

drivers/usb/cdns3/gadget.c: In function '__cdns3_gadget_init':
drivers/usb/cdns3/gadget.c:2665:23: warning:
 variable 'priv_dev' set but not used [-Wunused-but-set-variable]
drivers/usb/cdns3/gadget.c: In function cdns3_start_all_request:
drivers/usb/cdns3/gadget.c:357:24: warning:
 variable priv_req set but not used [-Wunused-but-set-variable]

They are never used, so can be removed.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Link: https://lore.kernel.org/r/20190903120445.22204-1-yuehaibing@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/cdns3/gadget.c

index 3094ad65ffc9635de5bd21d3617f9eb0e79b60ca..ddac638f0409892304d10aae1348bcce77920de3 100644 (file)
@@ -354,13 +354,11 @@ enum usb_device_speed cdns3_get_speed(struct cdns3_device *priv_dev)
 static int cdns3_start_all_request(struct cdns3_device *priv_dev,
                                   struct cdns3_endpoint *priv_ep)
 {
-       struct cdns3_request *priv_req;
        struct usb_request *request;
        int ret = 0;
 
        while (!list_empty(&priv_ep->deferred_req_list)) {
                request = cdns3_next_request(&priv_ep->deferred_req_list);
-               priv_req = to_cdns3_request(request);
 
                ret = cdns3_ep_run_transfer(priv_ep, request);
                if (ret)
@@ -2664,7 +2662,6 @@ err1:
 
 static int __cdns3_gadget_init(struct cdns3 *cdns)
 {
-       struct cdns3_device *priv_dev;
        int ret = 0;
 
        cdns3_drd_switch_gadget(cdns, 1);
@@ -2674,8 +2671,6 @@ static int __cdns3_gadget_init(struct cdns3 *cdns)
        if (ret)
                return ret;
 
-       priv_dev = cdns->gadget_dev;
-
        /*
         * Because interrupt line can be shared with other components in
         * driver it can't use IRQF_ONESHOT flag here.