habanalabs: remove node from list before freeing the node

[ Upstream commit f5eb7bf0c487a212ebda3c1b048fc3ccabacc147 ]

fix the following smatch warnings:

goya_pin_memory_before_cs()
warn: '&userptr->job_node' not removed from list

gaudi_pin_memory_before_cs()
warn: '&userptr->job_node' not removed from list

Signed-off-by: Koby Elbaz <kelbaz@habana.ai>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/misc/habanalabs/gaudi/gaudi.c b/drivers/misc/habanalabs/gaudi/gaudi.c
index 044b2ae196f93e0abc7fad106e451e6bfdda6869..37edd663603f69d086aeea4a2e1f4aca9eeaa1bb 100644 (file)
--- a/drivers/misc/habanalabs/gaudi/gaudi.c
+++ b/drivers/misc/habanalabs/gaudi/gaudi.c
@@ -3708,6 +3708,7 @@ already_pinned:
        return 0;
 
 unpin_memory:
+       list_del(&userptr->job_node);
        hl_unpin_host_memory(hdev, userptr);
 free_userptr:
        kfree(userptr);

diff --git a/drivers/misc/habanalabs/goya/goya.c b/drivers/misc/habanalabs/goya/goya.c
index 986ed3c072088b7506717da1d94ca039ecaccb0f..5b5d6275c2495b8b8d2698ad9e6c64438e4d2278 100644 (file)
--- a/drivers/misc/habanalabs/goya/goya.c
+++ b/drivers/misc/habanalabs/goya/goya.c
@@ -3190,6 +3190,7 @@ already_pinned:
        return 0;
 
 unpin_memory:
+       list_del(&userptr->job_node);
        hl_unpin_host_memory(hdev, userptr);
 free_userptr:
        kfree(userptr);