drm/i915/guc: enable GuC GGTT invalidation from the start

Invalidating the GuC TLBs while GuC is not loaded does not have negative
consequences, so if we're starting the driver with GuC enabled we can
use the GGTT invalidation function from the get-go, instead of switching
to it when we initialize the GuC objects.

In MTL, this fixes and issue where we try to overwrite the invalidation
function twice (once for each GuC), due to the GGTT being shared between
the primary and media GTs

Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Matt Roper <matthew.d.roper@intel.com>
Cc: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
Cc: John Harrison <John.C.Harrison@Intel.com>
Cc: Aravind Iddamsetty <aravind.iddamsetty@intel.com>
Reviewed-by: John Harrison <John.C.Harrison@Intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20221110175823.3867135-1-daniele.ceraolospurio@intel.com

diff --git a/drivers/gpu/drm/i915/gt/intel_ggtt.c b/drivers/gpu/drm/i915/gt/intel_ggtt.c
index 7644738b9cdbe1b91c7c6ed4f4b29bf13b6af674..8e326332e7c3c1966c3481feb1cb8bd3307826aa 100644 (file)
--- a/drivers/gpu/drm/i915/gt/intel_ggtt.c
+++ b/drivers/gpu/drm/i915/gt/intel_ggtt.c
@@ -988,7 +988,10 @@ static int gen8_gmch_probe(struct i915_ggtt *ggtt)
                        I915_VMA_GLOBAL_BIND | I915_VMA_LOCAL_BIND;
        }
 
-       ggtt->invalidate = gen8_ggtt_invalidate;
+       if (intel_uc_wants_guc(&ggtt->vm.gt->uc))
+               ggtt->invalidate = guc_ggtt_invalidate;
+       else
+               ggtt->invalidate = gen8_ggtt_invalidate;
 
        ggtt->vm.vma_ops.bind_vma    = intel_ggtt_bind_vma;
        ggtt->vm.vma_ops.unbind_vma  = intel_ggtt_unbind_vma;
@@ -1243,29 +1246,6 @@ int i915_ggtt_enable_hw(struct drm_i915_private *i915)
        return 0;
 }
 
-void i915_ggtt_enable_guc(struct i915_ggtt *ggtt)
-{
-       GEM_BUG_ON(ggtt->invalidate != gen8_ggtt_invalidate);
-
-       ggtt->invalidate = guc_ggtt_invalidate;
-
-       ggtt->invalidate(ggtt);
-}
-
-void i915_ggtt_disable_guc(struct i915_ggtt *ggtt)
-{
-       /* XXX Temporary pardon for error unload */
-       if (ggtt->invalidate == gen8_ggtt_invalidate)
-               return;
-
-       /* We should only be called after i915_ggtt_enable_guc() */
-       GEM_BUG_ON(ggtt->invalidate != guc_ggtt_invalidate);
-
-       ggtt->invalidate = gen8_ggtt_invalidate;
-
-       ggtt->invalidate(ggtt);
-}
-
 /**
  * i915_ggtt_resume_vm - Restore the memory mappings for a GGTT or DPT VM
  * @vm: The VM to restore the mappings for

diff --git a/drivers/gpu/drm/i915/gt/intel_gtt.h b/drivers/gpu/drm/i915/gt/intel_gtt.h
index d1900fec6cd1f3db8bcd27dee5a4157b34033757..7e5b888c1b68bc312be747223bd4ef305706c7f0 100644 (file)
--- a/drivers/gpu/drm/i915/gt/intel_gtt.h
+++ b/drivers/gpu/drm/i915/gt/intel_gtt.h
@@ -582,8 +582,6 @@ void intel_ggtt_unbind_vma(struct i915_address_space *vm,
 int i915_ggtt_probe_hw(struct drm_i915_private *i915);
 int i915_ggtt_init_hw(struct drm_i915_private *i915);
 int i915_ggtt_enable_hw(struct drm_i915_private *i915);
-void i915_ggtt_enable_guc(struct i915_ggtt *ggtt);
-void i915_ggtt_disable_guc(struct i915_ggtt *ggtt);
 int i915_init_ggtt(struct drm_i915_private *i915);
 void i915_ggtt_driver_release(struct drm_i915_private *i915);
 void i915_ggtt_driver_late_release(struct drm_i915_private *i915);

diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.c b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
index 52aede324788e9db073a2bc0ba364120913ca40b..c0b5aa6fde26033f5eb580d1701f5841a32e6b5b 100644 (file)
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
@@ -430,9 +430,6 @@ int intel_guc_init(struct intel_guc *guc)
        /* now that everything is perma-pinned, initialize the parameters */
        guc_init_params(guc);
 
-       /* We need to notify the guc whenever we change the GGTT */
-       i915_ggtt_enable_guc(gt->ggtt);
-
        intel_uc_fw_change_status(&guc->fw, INTEL_UC_FIRMWARE_LOADABLE);
 
        return 0;
@@ -457,13 +454,9 @@ out:
 
 void intel_guc_fini(struct intel_guc *guc)
 {
-       struct intel_gt *gt = guc_to_gt(guc);
-
        if (!intel_uc_fw_is_loadable(&guc->fw))
                return;
 
-       i915_ggtt_disable_guc(gt->ggtt);
-
        if (intel_guc_slpc_is_used(guc))
                intel_guc_slpc_fini(&guc->slpc);