bridge: switchdev: Use an helper to clear forward mark
authorIdo Schimmel <idosch@mellanox.com>
Sun, 3 Sep 2017 14:44:13 +0000 (17:44 +0300)
committerDavid S. Miller <davem@davemloft.net>
Tue, 5 Sep 2017 18:51:47 +0000 (11:51 -0700)
Instead of using ifdef in the C file.

Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Suggested-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Tested-by: Yotam Gigi <yotamg@mellanox.com>
Acked-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/bridge/br_device.c
net/bridge/br_private.h

index 5a7be3bddfa9f2d02f519df265426b2a29419b0c..f6b6a92f1c486aa94390a6bbe48de6c221110a22 100644 (file)
@@ -53,9 +53,7 @@ netdev_tx_t br_dev_xmit(struct sk_buff *skb, struct net_device *dev)
        brstats->tx_bytes += skb->len;
        u64_stats_update_end(&brstats->syncp);
 
-#ifdef CONFIG_NET_SWITCHDEV
-       skb->offload_fwd_mark = 0;
-#endif
+       br_switchdev_frame_unmark(skb);
        BR_INPUT_SKB_CB(skb)->brdev = dev;
 
        skb_reset_mac_header(skb);
index fd9ee73e0a6d6bfb0f1de47811e74012071d5196..e870cfc85b1476e0cd9456a51e6ee161d962d4f3 100644 (file)
@@ -1091,6 +1091,11 @@ int br_switchdev_set_port_flag(struct net_bridge_port *p,
                               unsigned long mask);
 void br_switchdev_fdb_notify(const struct net_bridge_fdb_entry *fdb,
                             int type);
+
+static inline void br_switchdev_frame_unmark(struct sk_buff *skb)
+{
+       skb->offload_fwd_mark = 0;
+}
 #else
 static inline int nbp_switchdev_mark_set(struct net_bridge_port *p)
 {
@@ -1119,6 +1124,10 @@ static inline void
 br_switchdev_fdb_notify(const struct net_bridge_fdb_entry *fdb, int type)
 {
 }
+
+static inline void br_switchdev_frame_unmark(struct sk_buff *skb)
+{
+}
 #endif /* CONFIG_NET_SWITCHDEV */
 
 #endif