drm/tegra: hub: Increase buffer size to ensure all possible values can be stored
authorLee Jones <lee@kernel.org>
Thu, 24 Aug 2023 07:37:00 +0000 (08:37 +0100)
committerThierry Reding <treding@nvidia.com>
Wed, 11 Oct 2023 20:52:43 +0000 (22:52 +0200)
When converting from int to string, we must allow for up to 10-chars (2147483647).

Fixes the following W=1 kernel build warning(s):

 drivers/gpu/drm/tegra/hub.c: In function ‘tegra_display_hub_probe’:
 drivers/gpu/drm/tegra/hub.c:1106:47: warning: ‘%u’ directive output may be truncated writing between 1 and 10 bytes into a region of size 4 [-Wformat-truncation=]
 drivers/gpu/drm/tegra/hub.c:1106:42: note: directive argument in the range [0, 4294967294]
 drivers/gpu/drm/tegra/hub.c:1106:17: note: ‘snprintf’ output between 6 and 15 bytes into a destination of size 8

Signed-off-by: Lee Jones <lee@kernel.org>
Signed-off-by: Thierry Reding <treding@nvidia.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230824073710.2677348-16-lee@kernel.org
drivers/gpu/drm/tegra/hub.c

index 1af5f8318d914679ee1b32a87d004af82cbd1c6a..f21e57e8599ee3e1e89be9fb1bd3bb72ac652d3f 100644 (file)
@@ -1101,7 +1101,7 @@ static int tegra_display_hub_probe(struct platform_device *pdev)
 
        for (i = 0; i < hub->soc->num_wgrps; i++) {
                struct tegra_windowgroup *wgrp = &hub->wgrps[i];
-               char id[8];
+               char id[16];
 
                snprintf(id, sizeof(id), "wgrp%u", i);
                mutex_init(&wgrp->lock);