hwrng: exynos - Runtime suspend device after init
authorKrzysztof Kozlowski <k.kozlowski@samsung.com>
Mon, 14 Mar 2016 00:07:12 +0000 (09:07 +0900)
committerHerbert Xu <herbert@gondor.apana.org.au>
Tue, 5 Apr 2016 12:35:42 +0000 (20:35 +0800)
The driver uses pm_runtime_put_noidle() after initialization so the
device might remain in active state if the core does not read from it
(the read callback contains regular runtime put). The put_noidle() was
chosen probably to avoid unneeded suspend and resume cycle after the
initialization.

However for this purpose autosuspend is enabled so it is safe to runtime
put just after the initialization.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/char/hw_random/exynos-rng.c

index ada08123252856aeec0314e5d4905e532b850899..d1fd21e9936810808c0051e185608f2d88cb51e7 100644 (file)
@@ -77,7 +77,8 @@ static int exynos_init(struct hwrng *rng)
 
        pm_runtime_get_sync(exynos_rng->dev);
        ret = exynos_rng_configure(exynos_rng);
-       pm_runtime_put_noidle(exynos_rng->dev);
+       pm_runtime_mark_last_busy(exynos_rng->dev);
+       pm_runtime_put_autosuspend(exynos_rng->dev);
 
        return ret;
 }