stm class: Prevent user-controllable allocations
authorAlexander Shishkin <alexander.shishkin@linux.intel.com>
Tue, 22 Dec 2015 15:25:21 +0000 (17:25 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 8 Feb 2016 06:43:17 +0000 (22:43 -0800)
Currently, the character device write method allocates a temporary buffer
for user's data, but the user's data size is not sanitized and can cause
arbitrarily large allocations via kzalloc() or an integer overflow that
will then result in overwriting kernel memory.

This patch trims the input buffer size to avoid these issues.

Reported-by: Sasha Levin <sasha.levin@oracle.com>
Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/hwtracing/stm/core.c

index 40a8b79ab7db4d12cf4313c939ce11cdaf6a7933..aef8ddb24451e3866173f582cb3b582d3d612273 100644 (file)
@@ -406,6 +406,9 @@ static ssize_t stm_char_write(struct file *file, const char __user *buf,
        char *kbuf;
        int err;
 
+       if (count + 1 > PAGE_SIZE)
+               count = PAGE_SIZE - 1;
+
        /*
         * if no m/c have been assigned to this writer up to this
         * point, use "default" policy entry