media: sun6i-mipi-csi2: Require both pads to be connected for streaming
authorPaul Kocialkowski <paul.kocialkowski@bootlin.com>
Fri, 9 Sep 2022 13:39:51 +0000 (14:39 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Fri, 25 Nov 2022 11:14:45 +0000 (11:14 +0000)
The bridge needs both its pads connected to be able to stream data.
Enforcing this is useful to produce an error when no sensor is
connected.

Fixes: af54b4f4c17f ("media: sunxi: Add support for the A31 MIPI CSI-2 controller")
Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c

index 30d6c0c5161f469cf2618f1b817e9219c3812190..340380a5f66fe3c344d404ad7961a8f3dd0597f4 100644 (file)
@@ -519,8 +519,10 @@ static int sun6i_mipi_csi2_bridge_setup(struct sun6i_mipi_csi2_device *csi2_dev)
 
        /* Media Pads */
 
-       pads[SUN6I_MIPI_CSI2_PAD_SINK].flags = MEDIA_PAD_FL_SINK;
-       pads[SUN6I_MIPI_CSI2_PAD_SOURCE].flags = MEDIA_PAD_FL_SOURCE;
+       pads[SUN6I_MIPI_CSI2_PAD_SINK].flags = MEDIA_PAD_FL_SINK |
+                                              MEDIA_PAD_FL_MUST_CONNECT;
+       pads[SUN6I_MIPI_CSI2_PAD_SOURCE].flags = MEDIA_PAD_FL_SOURCE |
+                                                MEDIA_PAD_FL_MUST_CONNECT;
 
        ret = media_entity_pads_init(&subdev->entity, SUN6I_MIPI_CSI2_PAD_COUNT,
                                     pads);