rtc: wm831x: Add IRQF_ONESHOT flag
authorHariprasad Kelam <hariprasad.kelam@gmail.com>
Thu, 11 Jul 2019 17:56:15 +0000 (23:26 +0530)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Sat, 13 Jul 2019 19:39:51 +0000 (21:39 +0200)
fix below issue reported by coccicheck
drivers/rtc/rtc-wm831x.c:436:7-32: ERROR: Threaded IRQ with no primary
handler requested without IRQF_ONESHOT

Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20190711175615.GA13651@hari-Inspiron-1545
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/rtc-wm831x.c

index d2e8b21c90c40e7e76e93cbd59521add4811a307..ccef887d2690112f736365912993a02de8b6938a 100644 (file)
@@ -435,7 +435,8 @@ static int wm831x_rtc_probe(struct platform_device *pdev)
 
        ret = devm_request_threaded_irq(&pdev->dev, alm_irq, NULL,
                                wm831x_alm_irq,
-                               IRQF_TRIGGER_RISING, "RTC alarm",
+                               IRQF_TRIGGER_RISING | IRQF_ONESHOT,
+                               "RTC alarm",
                                wm831x_rtc);
        if (ret != 0) {
                dev_err(&pdev->dev, "Failed to request alarm IRQ %d: %d\n",