kernel/cpu: Convert snprintf() to sysfs_emit()
authorLi Zhijian <lizhijian@fujitsu.com>
Tue, 16 Jan 2024 04:51:51 +0000 (12:51 +0800)
committerThomas Gleixner <tglx@linutronix.de>
Fri, 26 Jan 2024 17:25:16 +0000 (18:25 +0100)
Per filesystems/sysfs.rst, show() should only use sysfs_emit()
or sysfs_emit_at() when formatting the value to be returned to user space.

coccinelle complains that there are still a couple of functions that use
snprintf(). Convert them to sysfs_emit().

No functional change intended.

Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/20240116045151.3940401-40-lizhijian@fujitsu.com
kernel/cpu.c

index f05937581f26b6cd78a54093d81af2f7d689083b..ad7d0b00bce9931cbb93fbfe097f4451cd84dfa2 100644 (file)
@@ -3004,7 +3004,7 @@ static ssize_t control_show(struct device *dev,
                return sysfs_emit(buf, "%d\n", cpu_smt_num_threads);
 #endif
 
-       return snprintf(buf, PAGE_SIZE - 2, "%s\n", state);
+       return sysfs_emit(buf, "%s\n", state);
 }
 
 static ssize_t control_store(struct device *dev, struct device_attribute *attr,
@@ -3017,7 +3017,7 @@ static DEVICE_ATTR_RW(control);
 static ssize_t active_show(struct device *dev,
                           struct device_attribute *attr, char *buf)
 {
-       return snprintf(buf, PAGE_SIZE - 2, "%d\n", sched_smt_active());
+       return sysfs_emit(buf, "%d\n", sched_smt_active());
 }
 static DEVICE_ATTR_RO(active);