s390/cio: Use array indices instead of pointer arithmetic
authorBenjamin Block <bblock@linux.ibm.com>
Tue, 4 Apr 2023 18:33:59 +0000 (20:33 +0200)
committerAlexander Gordeev <agordeev@linux.ibm.com>
Fri, 3 Jan 2025 10:00:53 +0000 (11:00 +0100)
ccw_device_get_ciw() already uses array indices to iterate over the vector
of CIWs, but then switches to pointer arithmetic when returning the one it
found. Change this to make it more consistent.

Signed-off-by: Benjamin Block <bblock@linux.ibm.com>
Reviewed-by: Vineeth Vijayan <vneethv@linux.ibm.com>
Signed-off-by: Alexander Gordeev <agordeev@linux.ibm.com>
drivers/s390/cio/device_ops.c

index acd6790dba4dd1311d78e05afa0f41ad5b38aa3a..61c07b4a0fe892cc956530fe9b68ca6085804554 100644 (file)
@@ -445,7 +445,7 @@ struct ciw *ccw_device_get_ciw(struct ccw_device *cdev, __u32 ct)
                return NULL;
        for (ciw_cnt = 0; ciw_cnt < MAX_CIWS; ciw_cnt++)
                if (cdev->private->dma_area->senseid.ciw[ciw_cnt].ct == ct)
-                       return cdev->private->dma_area->senseid.ciw + ciw_cnt;
+                       return &cdev->private->dma_area->senseid.ciw[ciw_cnt];
        return NULL;
 }