scsi: qla2xxx: Remove unneeded if-null-free check

Eliminate the following coccicheck warning:

drivers/scsi/qla2xxx/qla_os.c:4622:2-7:
 WARNING: NULL check before some freeing functions is not needed.
drivers/scsi/qla2xxx/qla_os.c:4637:3-8:
 WARNING: NULL check before some freeing functions is not needed.

Link: https://lore.kernel.org/r/20210409120925.7122-1-linqiheng@huawei.com
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Qiheng Lin <linqiheng@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
index 12959e3874cb3ddc8eb06399dbc433999c8f4d68..d74c32f84ef58f2964d923c08003230f943d7f25 100644 (file)
--- a/drivers/scsi/qla2xxx/qla_os.c
+++ b/drivers/scsi/qla2xxx/qla_os.c
@@ -4618,8 +4618,7 @@ qla2x00_free_fw_dump(struct qla_hw_data *ha)
                dma_free_coherent(&ha->pdev->dev,
                    EFT_SIZE, ha->eft, ha->eft_dma);
 
-       if (ha->fw_dump)
-               vfree(ha->fw_dump);
+       vfree(ha->fw_dump);
 
        ha->fce = NULL;
        ha->fce_dma = 0;
@@ -4633,8 +4632,7 @@ qla2x00_free_fw_dump(struct qla_hw_data *ha)
        ha->fw_dump_len = 0;
 
        for (j = 0; j < 2; j++, fwdt++) {
-               if (fwdt->template)
-                       vfree(fwdt->template);
+               vfree(fwdt->template);
                fwdt->template = NULL;
                fwdt->length = 0;
        }