scsi: cxlflash: Refactor AFU capability checking
authorMatthew R. Ochs <mrochs@linux.vnet.ibm.com>
Thu, 22 Jun 2017 02:16:02 +0000 (21:16 -0500)
committerMartin K. Petersen <martin.petersen@oracle.com>
Mon, 26 Jun 2017 19:01:11 +0000 (15:01 -0400)
The existing AFU capability checking infrastructure is closely tied to
the command mode capability bits. In order to support new capabilities,
refactor the existing infrastructure to be more generic.

Signed-off-by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com>
Signed-off-by: Uma Krishnan <ukrishn@linux.vnet.ibm.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/cxlflash/common.h

index cbc0eb70ab470be35c5b9decba242ea94ab59e20..c96526e1fb11453c7b07d7763677373b41e2564b 100644 (file)
@@ -255,21 +255,21 @@ static inline bool afu_is_irqpoll_enabled(struct afu *afu)
        return !!afu->irqpoll_weight;
 }
 
-static inline bool afu_is_cmd_mode(struct afu *afu, u64 cmd_mode)
+static inline bool afu_has_cap(struct afu *afu, u64 cap)
 {
        u64 afu_cap = afu->interface_version >> SISL_INTVER_CAP_SHIFT;
 
-       return afu_cap & cmd_mode;
+       return afu_cap & cap;
 }
 
 static inline bool afu_is_sq_cmd_mode(struct afu *afu)
 {
-       return afu_is_cmd_mode(afu, SISL_INTVER_CAP_SQ_CMD_MODE);
+       return afu_has_cap(afu, SISL_INTVER_CAP_SQ_CMD_MODE);
 }
 
 static inline bool afu_is_ioarrin_cmd_mode(struct afu *afu)
 {
-       return afu_is_cmd_mode(afu, SISL_INTVER_CAP_IOARRIN_CMD_MODE);
+       return afu_has_cap(afu, SISL_INTVER_CAP_IOARRIN_CMD_MODE);
 }
 
 static inline u64 lun_to_lunid(u64 lun)