staging: lustre: llite: remove newline in fullname strings
authorJames Simmons <jsimmons@infradead.org>
Mon, 16 Apr 2018 04:15:02 +0000 (00:15 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 23 Apr 2018 12:57:41 +0000 (14:57 +0200)
In creating the full name of a xattr a new line was added that
was seen by the remote MDS server which confused it. Remove the
newline.

Signed-off-by: James Simmons <uja.ornl@yahoo.com>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9183
Reviewed-on: https://review.whamcloud.com/27240
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
Reviewed-by: Bob Glossman <bob.glossman@intel.com>
Reviewed-by: Sebastien Buisson <sbuisson@ddn.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/lustre/lustre/llite/xattr.c

index 42a6fb43078bbea9f7cc1d0d87f4b02fafac4fc9..4b1e565fd83f384af097c3ddd3f7fa9dcd25a50b 100644 (file)
@@ -136,7 +136,7 @@ ll_xattr_set_common(const struct xattr_handler *handler,
                        return -EPERM;
        }
 
-       fullname = kasprintf(GFP_KERNEL, "%s%s\n", handler->prefix, name);
+       fullname = kasprintf(GFP_KERNEL, "%s%s", handler->prefix, name);
        if (!fullname)
                return -ENOMEM;
        rc = md_setxattr(sbi->ll_md_exp, ll_inode2fid(inode),
@@ -435,7 +435,7 @@ static int ll_xattr_get_common(const struct xattr_handler *handler,
        if (handler->flags == XATTR_ACL_DEFAULT_T && !S_ISDIR(inode->i_mode))
                return -ENODATA;
 #endif
-       fullname = kasprintf(GFP_KERNEL, "%s%s\n", handler->prefix, name);
+       fullname = kasprintf(GFP_KERNEL, "%s%s", handler->prefix, name);
        if (!fullname)
                return -ENOMEM;
        rc = ll_xattr_list(inode, fullname, handler->flags, buffer, size,