bcachefs: Delete a faulty assertion
authorKent Overstreet <kent.overstreet@linux.dev>
Sat, 7 Jan 2023 03:58:19 +0000 (22:58 -0500)
committerKent Overstreet <kent.overstreet@linux.dev>
Sun, 22 Oct 2023 21:09:48 +0000 (17:09 -0400)
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
fs/bcachefs/btree_iter.c

index 326742e00159f641a29ba74a78d4642af17c1932..398db0faa8169dc5922856990d676ebba1b77a8d 100644 (file)
@@ -1011,12 +1011,11 @@ retry_all:
        }
 
        /*
-        * BTREE_ITER_NEED_RELOCK is ok here - if we called bch2_trans_unlock()
-        * and relock(), relock() won't relock since path->should_be_locked
-        * isn't set yet, which is all fine
+        * We used to assert that all paths had been traversed here
+        * (path->uptodate < BTREE_ITER_NEED_TRAVERSE); however, since
+        * path->Should_be_locked is not set yet, we we might have unlocked and
+        * then failed to relock a path - that's fine.
         */
-       trans_for_each_path(trans, path)
-               BUG_ON(path->uptodate >= BTREE_ITER_NEED_TRAVERSE);
 err:
        bch2_btree_cache_cannibalize_unlock(c);