misc/pvpanic-pci: register attributes via pci_driver
authorThomas Weißschuh <linux@weissschuh.net>
Thu, 11 Apr 2024 21:33:51 +0000 (23:33 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 29 Apr 2024 09:18:28 +0000 (11:18 +0200)
In __pci_register_driver(), the pci core overwrites the dev_groups field of
the embedded struct device_driver with the dev_groups from the outer
struct pci_driver unconditionally.

Set dev_groups in the pci_driver to make sure it is used.

This was broken since the introduction of pvpanic-pci.

Fixes: db3a4f0abefd ("misc/pvpanic: add PCI driver")
Cc: stable@vger.kernel.org
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
Fixes: ded13b9cfd59 ("PCI: Add support for dev_groups to struct pci_driver")
Link: https://lore.kernel.org/r/20240411-pvpanic-pci-dev-groups-v1-1-db8cb69f1b09@weissschuh.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/pvpanic/pvpanic-pci.c

index 9ad20e82785bcd6ade57d493e31152ecff334178..b21598a18f6da81568dedb0817bf74da55f81a15 100644 (file)
@@ -44,8 +44,6 @@ static struct pci_driver pvpanic_pci_driver = {
        .name =         "pvpanic-pci",
        .id_table =     pvpanic_pci_id_tbl,
        .probe =        pvpanic_pci_probe,
-       .driver = {
-               .dev_groups = pvpanic_dev_groups,
-       },
+       .dev_groups =   pvpanic_dev_groups,
 };
 module_pci_driver(pvpanic_pci_driver);