projects
/
linux-block.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
23fc86e
)
spi: img-spfi: fix reference leak in img_spfi_resume
author
Zhang Qilong
<zhangqilong3@huawei.com>
Mon, 2 Nov 2020 14:56:51 +0000
(22:56 +0800)
committer
Mark Brown
<broonie@kernel.org>
Mon, 2 Nov 2020 15:53:25 +0000
(15:53 +0000)
pm_runtime_get_sync will increment pm usage counter even it
failed. Forgetting to pm_runtime_put_noidle will result in
reference leak in img_spfi_resume, so we should fix it.
Fixes:
deba25800a12b
("spi: Add driver for IMG SPFI controller")
Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
Link:
https://lore.kernel.org/r/20201102145651.3875-1-zhangqilong3@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-img-spfi.c
patch
|
blob
|
blame
|
history
diff --git
a/drivers/spi/spi-img-spfi.c
b/drivers/spi/spi-img-spfi.c
index b068537375d609a0fc5a9f3018d1f23a01d6f2b8..5f05d519fbbd09188032e40f9626af7e24b5a498 100644
(file)
--- a/
drivers/spi/spi-img-spfi.c
+++ b/
drivers/spi/spi-img-spfi.c
@@
-731,8
+731,10
@@
static int img_spfi_resume(struct device *dev)
int ret;
ret = pm_runtime_get_sync(dev);
- if (ret)
+ if (ret) {
+ pm_runtime_put_noidle(dev);
return ret;
+ }
spfi_reset(spfi);
pm_runtime_put(dev);