drm: Make drm_pci_agp_init legacy
authorChris Wilson <chris@chris-wilson.co.uk>
Sat, 7 Mar 2020 09:37:02 +0000 (09:37 +0000)
committerChris Wilson <chris@chris-wilson.co.uk>
Mon, 9 Mar 2020 09:22:50 +0000 (09:22 +0000)
Pull the drm_pci_agp_init() underneath the legacy ifdeffry alongside its
only caller.

The diff chooses it to so it by moving drm_pci_agp_destroy earlier, but
the important bit is moving the #ifdef earlier before drm_pci_agp_init.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20200307093702.2269-1-chris@chris-wilson.co.uk
drivers/gpu/drm/drm_pci.c

index 5218475ad7e7e1fd9f8debd2750da9893dbbbca2..81aa215619821ab94b86c5207130248ebc5f94a0 100644 (file)
@@ -166,6 +166,18 @@ int drm_irq_by_busid(struct drm_device *dev, void *data,
        return drm_pci_irq_by_busid(dev, p);
 }
 
+void drm_pci_agp_destroy(struct drm_device *dev)
+{
+       if (dev->agp) {
+               arch_phys_wc_del(dev->agp->agp_mtrr);
+               drm_legacy_agp_clear(dev);
+               kfree(dev->agp);
+               dev->agp = NULL;
+       }
+}
+
+#ifdef CONFIG_DRM_LEGACY
+
 static void drm_pci_agp_init(struct drm_device *dev)
 {
        if (drm_core_check_feature(dev, DRIVER_USE_AGP)) {
@@ -180,18 +192,6 @@ static void drm_pci_agp_init(struct drm_device *dev)
        }
 }
 
-void drm_pci_agp_destroy(struct drm_device *dev)
-{
-       if (dev->agp) {
-               arch_phys_wc_del(dev->agp->agp_mtrr);
-               drm_legacy_agp_clear(dev);
-               kfree(dev->agp);
-               dev->agp = NULL;
-       }
-}
-
-#ifdef CONFIG_DRM_LEGACY
-
 static int drm_get_pci_dev(struct pci_dev *pdev,
                           const struct pci_device_id *ent,
                           struct drm_driver *driver)