gfs2: call truncate_inode_pages_final for address space glocks
authorBob Peterson <rpeterso@redhat.com>
Wed, 16 Sep 2020 16:06:23 +0000 (11:06 -0500)
committerAndreas Gruenbacher <agruenba@redhat.com>
Wed, 14 Oct 2020 21:54:42 +0000 (23:54 +0200)
Before this patch, we were not calling truncate_inode_pages_final for the
address space for glocks, which left the possibility of a leak. We now
take care of the problem instead of complaining, and we do it during
glock tear-down..

Signed-off-by: Bob Peterson <rpeterso@redhat.com>
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
fs/gfs2/glock.c

index 15c5c26f6ae77b7f264c831af96678bb962b11b1..19d4db4c44e78ecf8c69b4c8423a01e47b8d6c92 100644 (file)
@@ -270,7 +270,12 @@ static void __gfs2_glock_put(struct gfs2_glock *gl)
        gfs2_glock_remove_from_lru(gl);
        spin_unlock(&gl->gl_lockref.lock);
        GLOCK_BUG_ON(gl, !list_empty(&gl->gl_holders));
-       GLOCK_BUG_ON(gl, mapping && mapping->nrpages && !gfs2_withdrawn(sdp));
+       if (mapping) {
+               truncate_inode_pages_final(mapping);
+               if (!gfs2_withdrawn(sdp))
+                       GLOCK_BUG_ON(gl, mapping->nrpages ||
+                                    mapping->nrexceptional);
+       }
        trace_gfs2_glock_put(gl);
        sdp->sd_lockstruct.ls_ops->lm_put_lock(gl);
 }