drm/cirrus: Remove size test from cirrus_fb_create()
authorThomas Zimmermann <tzimmermann@suse.de>
Wed, 15 Feb 2023 16:15:12 +0000 (17:15 +0100)
committerThomas Zimmermann <tzimmermann@suse.de>
Mon, 13 Mar 2023 09:36:40 +0000 (10:36 +0100)
The DRM core implements a size check against the mode config's
limits when creating a framebuffer. [1] Remove the unnecessary
test from cirrus_fb_create() and remove the now-empty function.
Create framebuffers with drm_gem_fb_create_with_dirty().

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://elixir.bootlin.com/linux/v6.1/source/drivers/gpu/drm/drm_framebuffer.c#L287
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230215161517.5113-13-tzimmermann@suse.de
drivers/gpu/drm/tiny/cirrus.c

index c1ffbbe1d545a93729a1f0ebf70d087e5f617f99..c2d7bb7756298147433ba195489dd7b90a7986f2 100644 (file)
@@ -555,17 +555,8 @@ static int cirrus_pipe_init(struct cirrus_device *cirrus)
 /* ------------------------------------------------------------------ */
 /* cirrus framebuffers & mode config                                 */
 
-static struct drm_framebuffer*
-cirrus_fb_create(struct drm_device *dev, struct drm_file *file_priv,
-                const struct drm_mode_fb_cmd2 *mode_cmd)
-{
-       if (cirrus_check_size(mode_cmd->width, mode_cmd->height, NULL) < 0)
-               return ERR_PTR(-EINVAL);
-       return drm_gem_fb_create_with_dirty(dev, file_priv, mode_cmd);
-}
-
 static const struct drm_mode_config_funcs cirrus_mode_config_funcs = {
-       .fb_create = cirrus_fb_create,
+       .fb_create = drm_gem_fb_create_with_dirty,
        .atomic_check = drm_atomic_helper_check,
        .atomic_commit = drm_atomic_helper_commit,
 };