ALSA: emu10k1: Use pure devres PCI
authorPhilipp Stanner <phasta@kernel.org>
Wed, 23 Apr 2025 07:53:40 +0000 (09:53 +0200)
committerTakashi Iwai <tiwai@suse.de>
Thu, 24 Apr 2025 07:21:35 +0000 (09:21 +0200)
pci_request_regions() is a hybrid function which becomes managed if
pcim_enable_device() was called before. This hybrid nature is deprecated
and should not be used anymore.

Replace pci_request_regions() with the always-managed function
pcim_request_all_regions().

Signed-off-by: Philipp Stanner <phasta@kernel.org>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Link: https://patch.msgid.link/20250423075346.45907-23-phasta@kernel.org
sound/pci/emu10k1/emu10k1_main.c
sound/pci/emu10k1/emu10k1x.c

index 5b8a5ba825bdb2555cec7a13def744b062b50fa5..bbe252b8916cd91e84a678b71ca319f8b2ed8b00 100644 (file)
@@ -1563,7 +1563,7 @@ int snd_emu10k1_create(struct snd_card *card,
        else
                emu->gpr_base = FXGPREGBASE;
 
-       err = pci_request_regions(pci, "EMU10K1");
+       err = pcim_request_all_regions(pci, "EMU10K1");
        if (err < 0)
                return err;
        emu->port = pci_resource_start(pci, 0);
index 89043392f3ec73796eaedd612891a8227192aa5c..30ac37b5a21417b0c74239d758554a7e09b3ee2f 100644 (file)
@@ -884,7 +884,7 @@ static int snd_emu10k1x_create(struct snd_card *card,
        spin_lock_init(&chip->emu_lock);
        spin_lock_init(&chip->voice_lock);
   
-       err = pci_request_regions(pci, "EMU10K1X");
+       err = pcim_request_all_regions(pci, "EMU10K1X");
        if (err < 0)
                return err;
        chip->port = pci_resource_start(pci, 0);