staging: rtl8192e: Remove unused variables txbytes.., txbyt.. and signa..
authorPhilipp Hortmann <philipp.g.hortmann@gmail.com>
Wed, 25 Jan 2023 20:09:32 +0000 (21:09 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 27 Jan 2023 09:12:05 +0000 (10:12 +0100)
txbytesmulticast, txbytesbroadcast and signal_quality are initialized and
increased or set but never read. Remove dead code.

Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/c469f82619625fecbed95532967cc7ec2b12e5f9.1674675808.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
drivers/staging/rtl8192e/rtl8192e/rtl_core.c
drivers/staging/rtl8192e/rtl8192e/rtl_core.h

index 9d13fda33fbfa223acaf0ee5b4364af87f712a80..3989d484cc3303a0d72d3e269db082682541e47a 100644 (file)
@@ -1613,7 +1613,6 @@ static void _rtl92e_process_phyinfo(struct r8192_priv *priv, u8 *buffer,
 
                        tmp_val = priv->stats.slide_evm_total /
                                  slide_evm_statistics;
-                       priv->stats.signal_quality = tmp_val;
                        priv->stats.last_signal_strength_inpercent = tmp_val;
                }
 
index 2c5edda74e7331abe0fee0dfd5b3d0f10596a2ef..f8a8ece40ac18da8b83a7fea3ccfce7ceb064c87 100644 (file)
@@ -1616,11 +1616,7 @@ static short _rtl92e_tx(struct net_device *dev, struct sk_buff *skb)
        type = WLAN_FC_GET_TYPE(fc);
        pda_addr = header->addr1;
 
-       if (is_broadcast_ether_addr(pda_addr))
-               priv->stats.txbytesbroadcast += skb->len - fwinfo_size;
-       else if (is_multicast_ether_addr(pda_addr))
-               priv->stats.txbytesmulticast += skb->len - fwinfo_size;
-       else
+       if (!is_broadcast_ether_addr(pda_addr) && !is_multicast_ether_addr(pda_addr))
                priv->stats.txbytesunicast += skb->len - fwinfo_size;
 
        spin_lock_irqsave(&priv->irq_th_lock, flags);
index c6a4ac6ce959ebbda4f3fa25c9956b454cf8dac2..4cf776094ac0d5c93cf160ae1b29c36a29dbee0e 100644 (file)
@@ -184,8 +184,6 @@ enum reset_type {
 
 struct rt_stats {
        unsigned long received_rate_histogram[4][32];
-       unsigned long txbytesmulticast;
-       unsigned long txbytesbroadcast;
        unsigned long txbytesunicast;
        unsigned long rxbytesunicast;
        unsigned long txretrycount;
@@ -195,7 +193,6 @@ struct rt_stats {
        unsigned long   slide_rssi_total;
        unsigned long slide_evm_total;
        long signal_strength;
-       long signal_quality;
        long last_signal_strength_inpercent;
        long    recv_signal_power;
        u8 rx_rssi_percentage[4];