bcachefs: Fix a btree iterator leak
authorKent Overstreet <kent.overstreet@gmail.com>
Sun, 25 Jul 2021 00:20:02 +0000 (20:20 -0400)
committerKent Overstreet <kent.overstreet@linux.dev>
Sun, 22 Oct 2023 21:09:09 +0000 (17:09 -0400)
Signed-off-by: Kent Overstreet <kent.overstreet@gmail.com>
fs/bcachefs/btree_update_leaf.c

index c9de49286fb7ab46c4c04a9ffbd733544fa75594..18f4ba1e305c275779f7836ffa3e453976009b6f 100644 (file)
@@ -858,8 +858,10 @@ static int extent_handle_overwrites(struct btree_trans *trans,
                                                          BTREE_ITER_NOT_EXTENTS|
                                                          BTREE_ITER_INTENT);
                        ret = bch2_btree_iter_traverse(update_iter);
-                       if (ret)
+                       if (ret) {
+                               bch2_trans_iter_put(trans, update_iter);
                                goto out;
+                       }
 
                        bch2_trans_update(trans, update_iter, update,
                                          BTREE_UPDATE_INTERNAL_SNAPSHOT_NODE|