parport: Remove attach function pointer
authorDr. David Alan Gilbert <linux@treblig.org>
Thu, 2 May 2024 15:48:22 +0000 (16:48 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 3 Jul 2024 14:44:22 +0000 (16:44 +0200)
The attach function pointers haven't actually been called since:
  'commit 3275158fa52a ("parport: remove use of devmodel")'
topped adding entries to the drivers list.

If you're converting a driver, look at the 'match_port' function
pointer instead.

(There are lots of comment references to 'attach' all over, but they
probably need some deeper understanding to check the semantics
to see if they can be replaced by match_port).

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Acked-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Link: https://lore.kernel.org/r/20240502154823.67235-3-linux@treblig.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
include/linux/parport.h

index 2a4424b6015658e5b3523cb9786979fbda48acbb..190de3569e25c8df738f9a236514bd08bb5645a8 100644 (file)
@@ -252,7 +252,6 @@ struct parport {
 
 struct parport_driver {
        const char *name;
-       void (*attach) (struct parport *);
        void (*detach) (struct parport *);
        void (*match_port)(struct parport *);
        int (*probe)(struct pardevice *);