remoteproc: imx_rproc: use devm_ioremap
authorPeng Fan <peng.fan@nxp.com>
Sat, 6 Mar 2021 11:24:21 +0000 (19:24 +0800)
committerBjorn Andersson <bjorn.andersson@linaro.org>
Thu, 11 Mar 2021 18:02:43 +0000 (12:02 -0600)
We might need to map an region multiple times, becaue the region might
be shared between remote processors, such i.MX8QM with dual M4 cores.
So use devm_ioremap, not devm_ioremap_resource.

Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>
Reviewed-by: Richard Zhu <hongxing.zhu@nxp.com>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Link: https://lore.kernel.org/r/1615029865-23312-7-git-send-email-peng.fan@oss.nxp.com
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
drivers/remoteproc/imx_rproc.c

index 2a093cea49978b5520e67764af08ea6a4af10e02..47fc1d06be6aa57d5c7c653d6c02c27801f9279a 100644 (file)
@@ -296,7 +296,8 @@ static int imx_rproc_addr_init(struct imx_rproc *priv,
                if (b >= IMX7D_RPROC_MEM_MAX)
                        break;
 
-               priv->mem[b].cpu_addr = devm_ioremap_resource(&pdev->dev, &res);
+               /* Not use resource version, because we might share region */
+               priv->mem[b].cpu_addr = devm_ioremap(&pdev->dev, res.start, resource_size(&res));
                if (IS_ERR(priv->mem[b].cpu_addr)) {
                        dev_err(dev, "failed to remap %pr\n", &res);
                        err = PTR_ERR(priv->mem[b].cpu_addr);