gve: Avoid unnecessary use of comma operator
authorSimon Horman <horms@kernel.org>
Wed, 8 May 2024 08:32:19 +0000 (09:32 +0100)
committerJakub Kicinski <kuba@kernel.org>
Sat, 11 May 2024 01:40:49 +0000 (18:40 -0700)
Although it does not seem to have any untoward side-effects,
the use of ';' to separate to assignments seems more appropriate than ','.

Flagged by clang-18 -Wcomma

No functional change intended.
Compile tested only.

Reviewed-by: Shailend Chand <shailend@google.com>
Reviewed-by: Larysa Zaremba <larysa.zaremba@intel.com>
Signed-off-by: Simon Horman <horms@kernel.org>
Link: https://lore.kernel.org/r/20240508-gve-comma-v2-1-1ac919225f13@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/google/gve/gve_adminq.c

index 3df8243680d9096a7dd2f9da70d394333dbf673e..8ca0def176ef470e74c0f41fd180a7d03184f23e 100644 (file)
@@ -650,9 +650,9 @@ static void gve_adminq_get_create_rx_queue_cmd(struct gve_priv *priv,
                        GVE_RAW_ADDRESSING_QPL_ID : rx->data.qpl->id;
 
                cmd->create_rx_queue.rx_desc_ring_addr =
-                       cpu_to_be64(rx->desc.bus),
+                       cpu_to_be64(rx->desc.bus);
                cmd->create_rx_queue.rx_data_ring_addr =
-                       cpu_to_be64(rx->data.data_bus),
+                       cpu_to_be64(rx->data.data_bus);
                cmd->create_rx_queue.index = cpu_to_be32(queue_index);
                cmd->create_rx_queue.queue_page_list_id = cpu_to_be32(qpl_id);
                cmd->create_rx_queue.packet_buffer_size = cpu_to_be16(rx->packet_buffer_size);