spi: pxa2xx: Drop unneeded '!= 0' comparisons
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 17 May 2021 14:03:47 +0000 (17:03 +0300)
committerMark Brown <broonie@kernel.org>
Tue, 18 May 2021 13:05:33 +0000 (14:05 +0100)
In the few places it's redundant to compare against 0.
Drop the unneeded comparisons.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20210517140351.901-6-andriy.shevchenko@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-pxa2xx.c

index fb80f6013d54b4fc5311422bbc464b226354785e..f24851b3c020210d8efaa26762da1d8ee3e935a3 100644 (file)
@@ -1380,8 +1380,8 @@ static int setup(struct spi_device *spi)
        }
 
        chip->cr1 &= ~(SSCR1_SPO | SSCR1_SPH);
-       chip->cr1 |= (((spi->mode & SPI_CPHA) != 0) ? SSCR1_SPH : 0)
-                       | (((spi->mode & SPI_CPOL) != 0) ? SSCR1_SPO : 0);
+       chip->cr1 |= ((spi->mode & SPI_CPHA) ? SSCR1_SPH : 0) |
+                    ((spi->mode & SPI_CPOL) ? SSCR1_SPO : 0);
 
        if (spi->mode & SPI_LOOP)
                chip->cr1 |= SSCR1_LBM;
@@ -1859,7 +1859,7 @@ static int pxa2xx_spi_probe(struct platform_device *pdev)
        /* Register with the SPI framework */
        platform_set_drvdata(pdev, drv_data);
        status = spi_register_controller(controller);
-       if (status != 0) {
+       if (status) {
                dev_err(&pdev->dev, "problem registering spi controller\n");
                goto out_error_pm_runtime_enabled;
        }
@@ -1918,7 +1918,7 @@ static int pxa2xx_spi_suspend(struct device *dev)
        int status;
 
        status = spi_controller_suspend(drv_data->controller);
-       if (status != 0)
+       if (status)
                return status;
 
        pxa_ssp_disable(ssp);