sched: Fix TASK_WAKING & loadaverage breakage
authorIngo Molnar <mingo@elte.hu>
Wed, 16 Sep 2009 19:09:13 +0000 (21:09 +0200)
committerIngo Molnar <mingo@elte.hu>
Thu, 17 Sep 2009 07:51:20 +0000 (09:51 +0200)
Fix this:

top - 21:54:00 up  2:59,  1 user,  load average: 432512.33, 426421.74, 417432.74

Which happens because we now set TASK_WAKING before activate_task().

Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Mike Galbraith <efault@gmx.de>
LKML-Reference: <new-submission>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
kernel/sched.c

index 5049d959bb26d95f04a6ade71497bf2a6ef51cb0..969dfaef246553ce42eacc5881ad34a476d0a9b6 100644 (file)
@@ -2343,7 +2343,11 @@ static int try_to_wake_up(struct task_struct *p, unsigned int state,
        /*
         * In order to handle concurrent wakeups and release the rq->lock
         * we put the task in TASK_WAKING state.
+        *
+        * First fix up the nr_uninterruptible count:
         */
+       if (task_contributes_to_load(p))
+               rq->nr_uninterruptible--;
        p->state = TASK_WAKING;
        task_rq_unlock(rq, &flags);