crypto: hisilicon/zip - fix static check warning
authorYang Shen <shenyang39@huawei.com>
Mon, 7 Sep 2020 08:21:59 +0000 (16:21 +0800)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 18 Sep 2020 07:20:09 +0000 (17:20 +1000)
Fix some code for PClint warning:
    Warning - Suspicious Cast

Signed-off-by: Yang Shen <shenyang39@huawei.com>
Reviewed-by: Zhou Wang <wangzhou1@hisilicon.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/hisilicon/zip/zip_crypto.c

index e58baeb7cb9bdf6b3e1485f6b129b7e953fb54f2..246a43edd5c5f278bb064a5fd26a209d88540574 100644 (file)
@@ -16,7 +16,7 @@
 
 #define GZIP_HEAD_FLG_SHIFT                    3
 #define GZIP_HEAD_FEXTRA_SHIFT                 10
-#define GZIP_HEAD_FEXTRA_XLEN                  2
+#define GZIP_HEAD_FEXTRA_XLEN                  2UL
 #define GZIP_HEAD_FHCRC_SIZE                   2
 
 #define HZIP_GZIP_HEAD_BUF                     256
@@ -51,13 +51,13 @@ enum {
 
 struct hisi_zip_req {
        struct acomp_req *req;
-       int sskip;
-       int dskip;
+       u32 sskip;
+       u32 dskip;
        struct hisi_acc_hw_sgl *hw_src;
        struct hisi_acc_hw_sgl *hw_dst;
        dma_addr_t dma_src;
        dma_addr_t dma_dst;
-       int req_id;
+       u16 req_id;
 };
 
 struct hisi_zip_req_q {
@@ -119,7 +119,7 @@ static void hisi_zip_config_tag(struct hisi_zip_sqe *sqe, u32 tag)
 
 static void hisi_zip_fill_sqe(struct hisi_zip_sqe *sqe, u8 req_type,
                              dma_addr_t s_addr, dma_addr_t d_addr, u32 slen,
-                             u32 dlen, int sskip, int dskip)
+                             u32 dlen, u32 sskip, u32 dskip)
 {
        memset(sqe, 0, sizeof(struct hisi_zip_sqe));
 
@@ -573,7 +573,7 @@ static int hisi_zip_acompress(struct acomp_req *acomp_req)
                return head_size;
        }
 
-       req = hisi_zip_create_req(acomp_req, qp_ctx, (size_t)head_size, true);
+       req = hisi_zip_create_req(acomp_req, qp_ctx, head_size, true);
        if (IS_ERR(req))
                return PTR_ERR(req);