drm/msm/gpu: Add some WARN_ON()s
authorRob Clark <robdclark@chromium.org>
Wed, 24 Nov 2021 21:41:30 +0000 (13:41 -0800)
committerRob Clark <robdclark@chromium.org>
Tue, 30 Nov 2021 00:19:57 +0000 (16:19 -0800)
We don't expect either of these conditions to ever be true, so let's get
shouty if they are.

Signed-off-by: Rob Clark <robdclark@chromium.org>
Link: https://lore.kernel.org/r/20211124214151.1427022-6-robdclark@gmail.com
Signed-off-by: Rob Clark <robdclark@chromium.org>
drivers/gpu/drm/msm/adreno/adreno_gpu.c

index 7d1ff202e5d81ba26016e14e0aa9efe7ea3b2c0d..47cb40bdbd4394f4d8f31b2a5c2e7e9ce839f8ad 100644 (file)
@@ -504,6 +504,9 @@ int adreno_gpu_state_get(struct msm_gpu *gpu, struct msm_gpu_state *state)
        struct adreno_gpu *adreno_gpu = to_adreno_gpu(gpu);
        int i, count = 0;
 
+       WARN_ON(gpu->needs_hw_init);
+       WARN_ON(!mutex_is_locked(&gpu->lock));
+
        kref_init(&state->ref);
 
        ktime_get_real_ts64(&state->time);