ASoC: tlv320aic32x4: make array clocks static, makes object smaller
authorColin Ian King <colin.king@canonical.com>
Sun, 1 Aug 2021 06:48:07 +0000 (07:48 +0100)
committerMark Brown <broonie@kernel.org>
Mon, 2 Aug 2021 14:47:49 +0000 (15:47 +0100)
Don't populate the array clocks on the stack but instead it
static. Makes the object code smaller by 316 bytes.

Before:
   text    data     bss     dec     hex filename
  63668   28264       0   91932   1671c ./sound/soc/codecs/tlv320aic32x4.o

After:
   text    data     bss     dec     hex filename
  62616   29000       0   91616   165e0 ./sound/soc/codecs/tlv320aic32x4.o

(gcc version 10.2.0)

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20210801064807.138641-1-colin.king@canonical.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/tlv320aic32x4.c

index 8af739284fbec06aa712bc8c76b57ac6a99af867..8c6a287927e29a6cbcd2e726a721a069d23f9b21 100644 (file)
@@ -704,7 +704,7 @@ static int aic32x4_setup_clocks(struct snd_soc_component *component,
        unsigned long adc_clock_rate, dac_clock_rate;
        int ret;
 
-       struct clk_bulk_data clocks[] = {
+       static struct clk_bulk_data clocks[] = {
                { .id = "pll" },
                { .id = "nadc" },
                { .id = "madc" },
@@ -859,7 +859,7 @@ static int aic32x4_set_bias_level(struct snd_soc_component *component,
 {
        int ret;
 
-       struct clk_bulk_data clocks[] = {
+       static struct clk_bulk_data clocks[] = {
                { .id = "madc" },
                { .id = "mdac" },
                { .id = "bdiv" },
@@ -975,7 +975,7 @@ static int aic32x4_component_probe(struct snd_soc_component *component)
        u32 tmp_reg;
        int ret;
 
-       struct clk_bulk_data clocks[] = {
+       static struct clk_bulk_data clocks[] = {
                { .id = "codec_clkin" },
                { .id = "pll" },
                { .id = "bdiv" },
@@ -1126,7 +1126,7 @@ static int aic32x4_tas2505_component_probe(struct snd_soc_component *component)
        u32 tmp_reg;
        int ret;
 
-       struct clk_bulk_data clocks[] = {
+       static struct clk_bulk_data clocks[] = {
                { .id = "codec_clkin" },
                { .id = "pll" },
                { .id = "bdiv" },