usb: misc: onboard_usb_hub: Print symbolic error names
authorFrieder Schrempf <frieder.schrempf@kontron.de>
Mon, 27 Nov 2023 11:22:24 +0000 (12:22 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 27 Nov 2023 19:13:22 +0000 (19:13 +0000)
Instead of printing the decimal error codes, let's use the more
human-readable symbolic error names provided by the %pe printk
format specifier.

Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
Link: https://lore.kernel.org/r/20231127112234.109073-1-frieder@fris.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/misc/onboard_usb_hub.c

index 2b45404e9732cefca8b6a8cd93fa4f08a015cc76..6d122772a9706475a95cd370ffb70bfb1b76e756 100644 (file)
@@ -7,6 +7,7 @@
 
 #include <linux/device.h>
 #include <linux/export.h>
+#include <linux/err.h>
 #include <linux/gpio/consumer.h>
 #include <linux/init.h>
 #include <linux/kernel.h>
@@ -68,7 +69,7 @@ static int onboard_hub_power_on(struct onboard_hub *hub)
 
        err = regulator_bulk_enable(hub->pdata->num_supplies, hub->supplies);
        if (err) {
-               dev_err(hub->dev, "failed to enable supplies: %d\n", err);
+               dev_err(hub->dev, "failed to enable supplies: %pe\n", ERR_PTR(err));
                return err;
        }
 
@@ -88,7 +89,7 @@ static int onboard_hub_power_off(struct onboard_hub *hub)
 
        err = regulator_bulk_disable(hub->pdata->num_supplies, hub->supplies);
        if (err) {
-               dev_err(hub->dev, "failed to disable supplies: %d\n", err);
+               dev_err(hub->dev, "failed to disable supplies: %pe\n", ERR_PTR(err));
                return err;
        }
 
@@ -235,7 +236,7 @@ static void onboard_hub_attach_usb_driver(struct work_struct *work)
 
        err = driver_attach(&onboard_hub_usbdev_driver.drvwrap.driver);
        if (err)
-               pr_err("Failed to attach USB driver: %d\n", err);
+               pr_err("Failed to attach USB driver: %pe\n", ERR_PTR(err));
 }
 
 static int onboard_hub_probe(struct platform_device *pdev)
@@ -262,7 +263,7 @@ static int onboard_hub_probe(struct platform_device *pdev)
 
        err = devm_regulator_bulk_get(dev, hub->pdata->num_supplies, hub->supplies);
        if (err) {
-               dev_err(dev, "Failed to get regulator supplies: %d\n", err);
+               dev_err(dev, "Failed to get regulator supplies: %pe\n", ERR_PTR(err));
                return err;
        }