phy: cpcap-usb: Drop extra write to usb2 register
authorTony Lindgren <tony@atomide.com>
Sun, 22 Dec 2019 18:17:04 +0000 (10:17 -0800)
committerKishon Vijay Abraham I <kishon@ti.com>
Thu, 26 Dec 2019 10:57:53 +0000 (16:27 +0530)
We are currently writing the same register twice. Let's enable the USB
PHY only at the end of the function.

Cc: Merlijn Wajer <merlijn@wizzup.org>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Sebastian Reichel <sre@kernel.org>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
drivers/phy/motorola/phy-cpcap-usb.c

index da0b4eb8398deab4c27d07cda420f928d2d32830..12e71a315a2cba315cb4f1c9b28422e3cbc8b93f 100644 (file)
@@ -489,12 +489,6 @@ static int cpcap_usb_set_usb_mode(struct cpcap_phy_ddata *ddata)
        if (error)
                goto out_err;
 
-       error = regmap_update_bits(ddata->reg, CPCAP_REG_USBC2,
-                                  CPCAP_BIT_USBXCVREN,
-                                  CPCAP_BIT_USBXCVREN);
-       if (error)
-               goto out_err;
-
        error = regmap_update_bits(ddata->reg, CPCAP_REG_USBC3,
                                   CPCAP_BIT_PU_SPI |
                                   CPCAP_BIT_DMPD_SPI |