RDMA/hns: Fix an error code in hns_roce_create_srq()
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 17 Dec 2018 07:08:15 +0000 (10:08 +0300)
committerJason Gunthorpe <jgg@mellanox.com>
Tue, 18 Dec 2018 21:21:45 +0000 (14:21 -0700)
The function accidentally returns success on this error path.

Fixes: c7bcb13442e1 ("RDMA/hns: Add SRQ support for hip08 kernel mode")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Lijun Ou <oulijun@huawei.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/hw/hns/hns_roce_srq.c

index 463df60094e853d6a166494da993c3ed64cc5d50..6377e734e28eb668263718b461f0f6ed69bae0ef 100644 (file)
@@ -286,6 +286,7 @@ struct ib_srq *hns_roce_create_srq(struct ib_pd *pd,
                if (IS_ERR(srq->idx_que.umem)) {
                        dev_err(hr_dev->dev,
                                "ib_umem_get error for index queue\n");
+                       ret = PTR_ERR(srq->idx_que.umem);
                        goto err_srq_mtt;
                }